Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labs 2,3,4, 5submission #15

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Labs 2,3,4, 5submission #15

wants to merge 7 commits into from

Conversation

Mvichelie
Copy link

No description provided.

@RasmusBlanck
Copy link
Contributor

Lab 2 comments:

To fix the errors you're describing, you'll need to upgrade speechstate to the current version. I encountered the same error when trying to run your submission in your environment. Do either 'yarn up speechstate' or 'yarn upgrade --latest speechstate' depending on which yarn version you're using.

Some things that remain to fix:
(1) Currently, if the user answers anything that is not in the grammar, the machine still moves on to the next state, asking a new question. It should instead let the user know that it said something wrong, and re-raise the question to the user.
(2) Similarly, if the user is silent, the machine simply stops. It should instead tell the user that it didn't hear the input and re-raise the question.
(3) The machine never asks for confirmation, since there is no listening event in connection to the Confirmation state. Also, as soon as the machine reaches a state labelled 'final' it stops, so Confirmation shouldn't have that designation.

@Mvichelie Mvichelie changed the title Lab 2 submission Labs 2,3,4 submission Mar 7, 2024
@Mvichelie Mvichelie changed the title Labs 2,3,4 submission Labs 2,3,4, 5submission Mar 7, 2024
@RasmusBlanck
Copy link
Contributor

Comments labs 4 and 5:

There are a number of things that I would like you to fix. Since lab 5 is basically a refinement of lab 4, you can work on fixing all of these issues in lab 5 instead of working on lab 4 separately.

  • The machine is not properly picking up on the user's input. If I answer, in order, "Vlad", "Monday" and "10", the system replies

"You want to create an appointment at undefined with on Monday, let's proceed."
"I don't have information about ."

  • You should check that the NLU result is something that you actually want to assign to the context before assigning it. For example, if the result is undefined, the machine shouldn't store it, but instead ask the user for clarification or similar.

  • If I ask "Who is Marvin Gaye?" I get back
    "I don't have information about Marvin Gaye."
    "Enjoy your meeting!"
    which also seems like a pretty strange conversation.

(* Re-add the line
import { speechstate } from "speechstate";
to dm5.js so that the machine can run at all.)

  • The reprompts aren't working very well. If I'm just silent after "Hi, what can I do for you?", we get the following dialogue
    "Sorry, I didn't hear you. Will the meeting take the whole day?"
    "Sorry, I didn't understand. Will the meeting take the whole day?."
    "Sorry, I still didn't get that. Are you there?"

without any pause between the questions, and then it crashes with the error message:

Uncaught Error: Unable to evaluate guard 'LimitReached' in transition for event 'SPEAK_COMPLETE' in state node '(machine).Noinput3':
Guard 'LimitReached' is not implemented.

  • If I'm silent after being asked which day I like to have the meeting, the system never stops but just keeps repeating:
    "I didn't understand, can you repeat?"
    "On which day would you like to have a meeting?"
    ...

  • There seem to be no way to get help. If I just say "help" all the time, we get the following dialogue:
    Hi, what can I do for you?
    With whom would you like to have a meeting with?
    On which day would you like to have a meeting?
    I didn't understand, can you repeat?
    On which day would you like to have a meeting?
    What time is the meeting going to take place?
    You want to create an appointment at undefined with on undefined, let's proceed.
    I don't have information about .

  • I'm not sure how the confidence threshold is implemented. I never got any clarification questions from the system. Is it actually testing against the confidence threshold at some point?

@RasmusBlanck
Copy link
Contributor

RasmusBlanck commented Apr 8, 2024

Hi! I had a look at your most recent submission ("lab4 revised"), trying to run dm4.js, but it crashes as soon as I start it:

Uncaught Error: Invalid transition definition for state node 'DM.Prompt.Intents': Child state 'WithWhom' does not exist on 'DM.Prompt'

Does it run for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants