Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labs 2,3,4,5 submission #7

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Labs 2,3,4,5 submission #7

wants to merge 10 commits into from

Conversation

jshrdt
Copy link

@jshrdt jshrdt commented Feb 14, 2024

Hope I'm doing this correctly. Mainly I feel like I'm missing something about history states, but we couldn't work it out in the session on Tuesday either.

@RasmusBlanck
Copy link
Contributor

Good work!

With regards to the first issue you bring up in your report: I think the reason that the questions are not being re-raised is that the system is not done speaking the not-in-grammar message before entering the new state. For example, in ListenWho, the notinGrammar action is taken at the same time as the transition back to AskWho. You could try waiting for SPEAK_COMPLETE before going back to AskWho, for example by adding an extra state (so it would look similar in structure to the AskWho state).

The history state issue is more complicated. It seems that only a state transition from outside a state will trigger the history. So by moving the ASR_NOINPUT construct directly under DM, and having it call #DM.PromptAndAsk.hist it almost works. (And I let the ASR_NOINPUT signal trigger a move to a state DM.NoInput, in which we can wait for SPEAK_COMPLETE before moving on.) The problem is now that deep history remembers all child states, so reentering PromptAndAsk will remember, for example, the state ListenWho rather than AskWho, so the question is never re-raised. Shallow history, on the other hand, only remembers the child state of its own parent state, so when ASR_NOINPUT is sent anywhere in GetDay, the history will remember to go back to GetDay, but not to the correct child state. I'm sure this can be solved by a careful nesting of states, or multiple history states, but it'll probably take some work.

@vladmaraev vladmaraev force-pushed the main branch 3 times, most recently from 389c1aa to f89ca27 Compare February 21, 2024 08:44
@jshrdt jshrdt changed the title Lab 2 submission Labs 2,3 submission” Feb 21, 2024
@jshrdt jshrdt changed the title Labs 2,3 submission” Labs 2,3 submission Feb 21, 2024
@jshrdt
Copy link
Author

jshrdt commented Feb 23, 2024

Addition for the EndpointID Lab3: "b62db1aa-d941-4022-9d06-47d952366ef2"

@jshrdt jshrdt changed the title Labs 2,3 submission Labs 2,3,4 submission Feb 28, 2024
@jshrdt jshrdt changed the title Labs 2,3,4 submission Labs 2,3,4,5 submission Mar 6, 2024
@RasmusBlanck
Copy link
Contributor

Lab 4 comments:

Well done!

It's nice to have slot filling of the person already in the user's first utterance. One improvement along these lines could be to make it possible to say, for example, "Monday at 10" filling both slots in one go. It's also very helpful to get the list of available persons in the help message. Especially since it took me a while to find your json file. :-)

@RasmusBlanck
Copy link
Contributor

Good work!

A couple of minor observations:

There seem to be no reprompt after "... is not a valid day".

I was also able to record this conversation (don't ask...)
-"Did you say string quartet concert?"
-"Yes?"
-"Who are you meeting with?"
It somehow makes sense, but I'm not sure if it's intended behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants