-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lab 2, 3, 4, 5 submission #8
base: main
Are you sure you want to change the base?
Conversation
Good! I think the idea for the "autostart" was that the machine would start either by click or automatically after 10 secs, and I see that you implemented the autostart after the click, but I think it's fine! Maybe take a look at delayed / after transitions in XState v5, if you haven't already. Good job. |
389c1aa
to
f89ca27
Compare
Hey, for lab 4, I see that you used intents and entities, that works fine! But the appointment section still relies only on a grammar. So I would suggest relying on entities or intents for recognizing the different steps in the appointment process in any way you see works best. Message me if you need some help with this and we can take a look together. |
I apologize for the previous comment, I can see now that you do rely on entities in both lab 4 and 5. The point of the NLU part was that we get more flexibility in utterances when we "communicate" with the machine. With entities, for example, we recognize them in our full sentences and work with them (e.g. utterance: "I want to meet with Vlad", entity: "Vlad"), but it is true that this is not a specified anywhere, so technically speaking you have used the designed tools to complete the labs. |
No description provided.