Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lab 2, 3, 4, 5 submission #8

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

ahenriksson
Copy link

No description provided.

@nastaiza14
Copy link
Collaborator

Good! I think the idea for the "autostart" was that the machine would start either by click or automatically after 10 secs, and I see that you implemented the autostart after the click, but I think it's fine! Maybe take a look at delayed / after transitions in XState v5, if you haven't already. Good job.

@vladmaraev vladmaraev force-pushed the main branch 3 times, most recently from 389c1aa to f89ca27 Compare February 21, 2024 08:44
@ahenriksson ahenriksson changed the title Lab 2 submission Lab 2, 3 submission Feb 22, 2024
@ahenriksson ahenriksson changed the title Lab 2, 3 submission Lab 2, 3, 4 submission Feb 29, 2024
@ahenriksson ahenriksson changed the title Lab 2, 3, 4 submission Lab 2, 3, 4, 5 submission Mar 7, 2024
@nastaiza14
Copy link
Collaborator

nastaiza14 commented Mar 22, 2024

Hey, for lab 4, I see that you used intents and entities, that works fine! But the appointment section still relies only on a grammar.
It's fine to do that to some extent, but the goal for this lab was so that we can speak more naturally to the system (and right now if I say something like "The meeting is on Tuesday" it will not get it, because only "Tuesday" is in the grammar).

So I would suggest relying on entities or intents for recognizing the different steps in the appointment process in any way you see works best.

Message me if you need some help with this and we can take a look together.

@nastaiza14
Copy link
Collaborator

I apologize for the previous comment, I can see now that you do rely on entities in both lab 4 and 5.

The point of the NLU part was that we get more flexibility in utterances when we "communicate" with the machine. With entities, for example, we recognize them in our full sentences and work with them (e.g. utterance: "I want to meet with Vlad", entity: "Vlad"), but it is true that this is not a specified anywhere, so technically speaking you have used the designed tools to complete the labs.
No need to modify them further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants