Skip to content

3. Code Contribution

Jump to bottom
merforga edited this page Jul 11, 2018 · 4 revisions

Contributing

Almost anyone can contribute to this project. The main issue comes down to understanding the relationship and linking between all facets of the application and the limited system resources available to do it. In order for your contribution to be implemented, we require the following:

  • Knowledge of basic game mechanics and interactions
  • Understanding of the GW2R spec
  • Understanding of the ARCDPS log file spec
  • Understanding of Python and/or willingness to learn
  • Tenacity and perseverance to actually implement the change

Process

  1. Fork the repo to your own
  2. Create a branch and commit your code changes there. Give it a meaningful name e.g "feature-boonfix"
  3. Squash your commits and create a pull request to the develop branch for approval.
  4. In your request, ensure you provide adequate detail about what you were attempting to change, expected outcome, and link back to issue in the issues log.
  5. if any additional libraries are required, please ensure you specify them in the issues log.

Once your request has been merged with develop, we'll deploy it to UAT for testing (http://uat.gw2raidar.com). It may be possible to have multiple features and changes being tested at the same time. Once both we and you are happy with the changes, they'll be merged into master and deployed to production. If there are any issues, they'll be raised with you to amend where appropriate.

NEVER SEND A PULL REQUEST TO THE MASTER BRANCH. ALL PULL REQUESTS TO MASTER BRANCH WILL AUTOMATICALLY BE DENIED WITHOUT REVIEW

Rebase Lining

When rebaselining your code, always rebase against Master. This ensures your code is always using the latest, stable release.

Want to know more or have any questions? Hop on our Discord for further info.

Meow

Clone this wiki locally