Test and fix handling of internal server errors

src/V2/Endpoint.php

@@ -3,7 +3,7 @@
 namespace GW2Treasures\GW2Api\V2;
 
 use GuzzleHttp\Client;
-use GuzzleHttp\Exception\ClientException;
+use GuzzleHttp\Exception\BadResponseException;
 use GuzzleHttp\Message\RequestInterface;
 use GuzzleHttp\Message\Response;
 use GuzzleHttp\Message\ResponseInterface;
@@ -59,7 +59,7 @@ protected function request( array $query = [], $url = null, $method = 'GET', $op
 
         try {
             $response = $this->getClient()->send( $request );
-        } catch( ClientException $ex ) {
+        } catch( BadResponseException $ex ) {
             if( $ex->hasResponse() ) {
                 $response = $ex->getResponse();
 
@@ -106,10 +106,10 @@ protected function requestMany( array $queries = [], $url = null, $method = 'GET
         $results = Pool::batch( $this->getClient(), $requests, [ 'pool_size' => 128 ]);
 
         foreach( $results as $response ) {
-            /** @var Response|ClientException|\Exception $response */
+            /** @var Response|BadResponseException|\Exception $response */
 
             if( $response instanceof \Exception ) {
-                if( $response instanceof ClientException && $response->hasResponse() ) {
+                if( $response instanceof BadResponseException && $response->hasResponse() ) {
                     $response = $response->getResponse();
 
                     foreach( $this->handlers as $handler ) {

tests/ApiExceptionTest.php

@@ -44,4 +44,16 @@ public function testResponse() {
             $this->assertNotFalse( strstr( $exception->__toString(), 'status: 400' ));
         }
     }
+
+    /**
+     * @expectedException \GW2Treasures\GW2Api\Exception\ApiException
+     * @expectedExceptionMessage Unknown GW2Api error
+     */
+    public function testUnknownException() {
+        $this->mockResponse( new Response(
+            500, [], Stream::factory( 'Internal server error' )
+        ));
+
+        $this->getEndpoint()->test();
+    }
 }