Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install.sh | Bump qdrant version #155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ShambaC
Copy link

@ShambaC ShambaC commented Jan 30, 2025

Qdrant version needs to be updated as the older version of Qdrant installed with gaianet does not support snapshots created using newer version of qdrant.

Copy link
Contributor

juntao commented Jan 30, 2025

Hello, I am a code review agent on flows.network. Here are my reviews of changed source code files in this PR.


install.sh

Potential issues

  1. Redundant Download in Qdrant Installation: The script redundantly downloads the Qdrant source code archive after downloading and extracting the binary, which is unnecessary and inefficient.

    • Issue: check_curl_silent https://github.com/qdrant/qdrant/archive/refs/tags/$qdrant_version.tar.gz $gaianet_base_dir/qdrant/$qdrant_version.tar.gz
  2. Incorrect URL for WasmEdge Installation: The script uses a hardcoded URL that points to the main branch of the WasmEdge repository, which may not correspond to the specified version.

    • Issue: curl -sSf https://raw.githubusercontent.com/WasmEdge/WasmEdge/master/utils/install_v2.sh | bash -s -- ...
  3. Incorrect File Handling in Backup and Migration: The script attempts to set the full path of backup_to_file and migrated_from_file, which can lead to errors since these variables should represent file paths, not directories.

    • Issue: backup_to_file=$(cd "$backup_to_file" && pwd) and migrated_from_file=$(cd "$migrated_from_file" && pwd)

Summary of changes

    • Updated Qdrant version: Changed qdrant_version from "v1.11.4" to "v1.13.2".
  • No other significant changes: Minor version update without affecting other variables or logic.
  • Patch focus: Solely targets the version bump for Qdrant in the script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants