Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use lazy_loader with subpackages #139

Merged
merged 4 commits into from
Feb 10, 2024

Conversation

nstarman
Copy link
Contributor

@nstarman nstarman commented Feb 10, 2024

This follows the normal usage of galax, e.g. import galax.dynamics as gd.
The current format destroys the lazy import right away.

Unfortunately scientific-python/lazy-loader#94 means we can't do star imports in the stub files. When that's resolved everything will be a lot simpler.

@nstarman nstarman added this to the v0.1 milestone Feb 10, 2024
Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (c972652) 88.44% compared to head (66d8ac4) 88.43%.
Report is 7 commits behind head on main.

Files Patch % Lines
...amics/_dynamics/mockstream/mockstream_generator.py 72.22% 5 Missing ⚠️
src/galax/dynamics/_dynamics/orbit.py 84.00% 4 Missing ⚠️
src/galax/potential/_potential/base.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
- Coverage   88.44%   88.43%   -0.01%     
==========================================
  Files          42       45       +3     
  Lines        1324     1375      +51     
==========================================
+ Hits         1171     1216      +45     
- Misses        153      159       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nstarman nstarman marked this pull request as ready for review February 10, 2024 20:45
@nstarman nstarman merged commit 2743510 into GalacticDynamics:main Feb 10, 2024
12 of 13 checks passed
@nstarman nstarman deleted the lazy-lower branch February 10, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant