-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import pages from the Galaxypedia #67
Conversation
@sharpy66 Can you please format this PR with prettier so checks pass and the preview deployment can be made? Not sure why preview deployments aren't being made on PRs that fail formatting checks, will look into that later. |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
category page redirects not working is fine
weird. pandoc should've formatted them correctly, but i digress. might be wise to keep track of pages like these. maybe via a hugo tag
perfect. hate those
this ties into #20
i did go through other templates and honestly didnt see much of a need for them. if you could give me a list of templates you need, i can go through them and see which ones i want to keep
the idea was that user links would be converted to github user links. but most of the community wouldnt have a github account, which begs the question as to why @cswimr spent 9 years working on the github user link template 😭 but regardless, we can probably switch them to their roblox profiles, or just remove them. special page links should just be deleted
should probably make an issue for this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are the ships under content/wiki
? they should be under content/wiki/ships
content/wiki/Fighters/Bonehawk.md
Outdated
title: Bonehawk | ||
--- | ||
|
||
{{< shipInfobox >}} {{< notices/limitedShip >}} The **_Bonehawk_** is an exclusive [Fighter]({{< ref "/categories/" >}}fighters) only found on the [Kapisi]({{< ref "/wiki/" >}}Kapisi). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cswimr okay but seriously why is prettier doing this. putting templates on new lines is a lot more readable than whatever it's doing here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That isn't due to prettier, the script is based on an older version of Deity.md which had them placed like that. Simple change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It actually is due to Prettier, but there's a simple fix for it. See how the shortcodes are formatted in the Ships archetype. That's more compliant with markdown anyway, as newlines in markdown are not newlines unless the line above the newline contains two trailing spaces.
Invalid:
{{< shipInfobox >}}
{{< notice/limitedShip >}}
The ...
Valid:
<!-- replace <space> with actual whitespace, I have no good way of showing whitespace here -->
{{< shipInfobox >}}<space><space>
{{< notice/limitedShip >}}<space><space>
The ...
Valid:
{{< shipInfobox >}}
{{< notice/limitedShip >}}
The ...
PR in general is good. i definitely can see some issues and i think that links are done rather weirdly (whats with all of that ref stuff?) but nothing we cant work through. good work! |
I don't know how or why, but that commit specifically was simply the /ships/ folder... and nothing else. |
looking a lot better now! will review it when i get the time |
@Galaxypedia-Wiki/development-team this PR looks good to me and i'd like to get it in if possible. what's the plan here? do we want to get categorization in before we merge or is it fine to merge as is? |
I believe this has category pages, right? They're just barebones? |
Yeah it does, see: https://sharpy66-migrate-pages.galaxypedia.pages.dev/categories/carriers/ |
right, it does. so are we all good here? with the original galaxypedia being read only, and this one not having anything on it, we've virtually got two dysfunctional wiki's and thats not a great place to be in |
Looks like taxonomy pages are a bit broken, gonna update this branch and see if it's fixed on rebuild. |
Not sure if that'll fix taxonomy pages completely but it's a start |
Footer fix is OOS for this pr, we should either fix it before merging this and update this branch after, or do it later. Will require refactoring of the footer partial. |
@cswimr like i've said before i really don't want to wait on this PR any longer. if the remaining issues can be weeded out after the fact, that'd be good. let's have our priorities on merging this asap. i'll set a deadline of before the end of this year if it helps |
i'm on mobile and can't load the diff screen cause it's too big. so i can't approve. just consider this approved |
Known issues:
Definitely more things I am not aware of at this time.