Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import pages from the Galaxypedia #67

Merged
merged 15 commits into from
Jan 1, 2025

Conversation

sharpy66
Copy link
Contributor

@sharpy66 sharpy66 commented Dec 18, 2024

Known issues:

  • Category page redirects do not work
  • Tables are not formatted properly
  • Collapsible elements like those on the main ships page do not work
  • Category pages are bare-bones
  • There are only ship infoboxes(others are skipped as no replacement currently exists in hugopedia)
  • User and special page links do not work
  • Main/home page has no links (use the search bar to get anywhere)

Definitely more things I am not aware of at this time.

@github-actions github-actions bot added site:platform Issues concerning the platform (hugo) site:content Concerns site content labels Dec 18, 2024
@cswimr
Copy link
Member

cswimr commented Dec 18, 2024

@sharpy66 Can you please format this PR with prettier so checks pass and the preview deployment can be made? Not sure why preview deployments aren't being made on PRs that fail formatting checks, will look into that later.

@github-actions github-actions bot added the site:tooling Concerns development tooling label Dec 18, 2024
@github-actions github-actions bot removed the site:tooling Concerns development tooling label Dec 18, 2024
Copy link

github-actions bot commented Dec 18, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
galaxypedia ✅ Ready (View Log) Visit Preview 7f64a77

@smallketchup82
Copy link
Member

Known issues:

  • Category page redirects do not work

category page redirects not working is fine

  • Tables are not formatted properly

weird. pandoc should've formatted them correctly, but i digress. might be wise to keep track of pages like these. maybe via a hugo tag

  • Collapsible elements like those on the main ships page do not work

perfect. hate those

  • Category pages are bare-bones

this ties into #20

  • There are only ship infoboxes(others are skipped as no replacement currently exists in hugopedia)

i did go through other templates and honestly didnt see much of a need for them. if you could give me a list of templates you need, i can go through them and see which ones i want to keep

  • User and special page links do not work

the idea was that user links would be converted to github user links. but most of the community wouldnt have a github account, which begs the question as to why @cswimr spent 9 years working on the github user link template 😭

but regardless, we can probably switch them to their roblox profiles, or just remove them. special page links should just be deleted

  • Main/home page has no links (use the search bar to get anywhere)

should probably make an issue for this

@smallketchup82 smallketchup82 added the priority:medium good to have in the near future label Dec 18, 2024
Copy link
Member

@smallketchup82 smallketchup82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are the ships under content/wiki? they should be under content/wiki/ships

title: Bonehawk
---

{{< shipInfobox >}} {{< notices/limitedShip >}} The **_Bonehawk_** is an exclusive [Fighter]({{< ref "/categories/" >}}fighters) only found on the [Kapisi]({{< ref "/wiki/" >}}Kapisi).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cswimr okay but seriously why is prettier doing this. putting templates on new lines is a lot more readable than whatever it's doing here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That isn't due to prettier, the script is based on an older version of Deity.md which had them placed like that. Simple change.

Copy link
Member

@cswimr cswimr Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It actually is due to Prettier, but there's a simple fix for it. See how the shortcodes are formatted in the Ships archetype. That's more compliant with markdown anyway, as newlines in markdown are not newlines unless the line above the newline contains two trailing spaces.

Invalid:

{{< shipInfobox >}}
{{< notice/limitedShip >}}
The ...

Valid:

<!-- replace <space> with actual whitespace, I have no good way of showing whitespace here -->
{{< shipInfobox >}}<space><space>
{{< notice/limitedShip >}}<space><space>
The ...

Valid:

{{< shipInfobox >}}

{{< notice/limitedShip >}}

The ...

@smallketchup82
Copy link
Member

PR in general is good. i definitely can see some issues and i think that links are done rather weirdly (whats with all of that ref stuff?) but nothing we cant work through. good work!

@smallketchup82 smallketchup82 changed the title Migrate Pages Import pages from the Galaxypedia Dec 18, 2024
@sharpy66
Copy link
Contributor Author

why are the ships under content/wiki? they should be under content/wiki/ships

I don't know how or why, but that commit specifically was simply the /ships/ folder... and nothing else.

@smallketchup82
Copy link
Member

looking a lot better now! will review it when i get the time

@smallketchup82 smallketchup82 added priority:high needs to be worked on asap and removed priority:medium good to have in the near future labels Dec 27, 2024
@smallketchup82 smallketchup82 marked this pull request as ready for review December 28, 2024 04:59
@smallketchup82 smallketchup82 requested review from a team as code owners December 28, 2024 04:59
@smallketchup82
Copy link
Member

@Galaxypedia-Wiki/development-team this PR looks good to me and i'd like to get it in if possible. what's the plan here? do we want to get categorization in before we merge or is it fine to merge as is?

@cswimr
Copy link
Member

cswimr commented Dec 28, 2024

I believe this has category pages, right? They're just barebones?

@cswimr
Copy link
Member

cswimr commented Dec 28, 2024

@smallketchup82
Copy link
Member

smallketchup82 commented Dec 28, 2024

right, it does. so are we all good here? with the original galaxypedia being read only, and this one not having anything on it, we've virtually got two dysfunctional wiki's and thats not a great place to be in

@cswimr
Copy link
Member

cswimr commented Dec 28, 2024

Looks like taxonomy pages are a bit broken, gonna update this branch and see if it's fixed on rebuild.

@cswimr
Copy link
Member

cswimr commented Dec 28, 2024

Not sure if that'll fix taxonomy pages completely but it's a start

@cswimr
Copy link
Member

cswimr commented Dec 28, 2024

Footer fix is OOS for this pr, we should either fix it before merging this and update this branch after, or do it later. Will require refactoring of the footer partial.

@smallketchup82
Copy link
Member

@cswimr like i've said before i really don't want to wait on this PR any longer. if the remaining issues can be weeded out after the fact, that'd be good.

let's have our priorities on merging this asap. i'll set a deadline of before the end of this year if it helps

@smallketchup82
Copy link
Member

i'm on mobile and can't load the diff screen cause it's too big. so i can't approve.

just consider this approved

@smallketchup82 smallketchup82 merged commit a3bf763 into Galaxypedia-Wiki:main Jan 1, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high needs to be worked on asap site:content Concerns site content site:platform Issues concerning the platform (hugo)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants