Match against LLVMValString in overrides (#2148)
#2149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLVM will sometimes optimize `uint8_t` arrays into top-level string constants.
For example, Clang will optimize `uint8_t xs[4] = {0,1,2,3};` into the LLVM
string constant `"\00\01\02\03"`. This is still a value of type `[4 x i8]`, but
it uses string syntax for convenience. `crucible-llvm` mirrors this choice by
having a dedicated `LLVMValString` value alongside the more general
`LLVMValArray`, with the former using a `ByteString` as its payload for
convenience.
While SAW's LLVM override matching logic had cases for `LLVMValArray`, it did
_not_ have cases for `LLVMValString`, which meant that any override that needs
to match on an LLVM string constant argument would fail. This is easily fixed
by adding the missing cases.
Fixes #2148.
sauclovian-g
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM will sometimes optimize
uint8_tarrays into top-level string constants. For example, Clang will optimizeuint8_t xs[4] = {0,1,2,3};into the LLVM string constant"\00\01\02\03". This is still a value of type[4 x i8], but it uses string syntax for convenience.crucible-llvmmirrors this choice by having a dedicatedLLVMValStringvalue alongside the more generalLLVMValArray, with the former using aByteStringas its payload for convenience.While SAW's LLVM override matching logic had cases for
LLVMValArray, it did not have cases forLLVMValString, which meant that any override that needs to match on an LLVM string constant argument would fail. This is easily fixed by adding the missing cases.Fixes #2148.