Fix translator-tests after GaloisInc/crucible#1150
#44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build is easily fixed by switching from the (now-removed) `ACFG` type in favor of `AnyCFG`. While I was in town, I also enabled the various `stubs`-related test suites in the CI. Fixes #37.
|
It looks like CI is missing Z3: Would you mind fixing that as well, so that CI can confirm your test fixes? |
RyanGlScott
force-pushed
the
T37-fix-translator-tests
branch
from
19a4ad9 to
7a7ab14
Compare
RyanGlScott
force-pushed
the
T37-fix-translator-tests
branch
from
7a7ab14 to
ae96882
Compare
|
Oops, that's embarrassing. I've fixed that now. |
langston-barrett
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build is easily fixed by switching from the (now-removed)
ACFGtype in favor ofAnyCFG. While I was in town, I also enabled the variousstubs-related test suites in the CI.Fixes #37.