Refactor: Migrate Chatroom to Socket Service Architecture #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored ChatroomProvider and SocketProvider to use the new SocketService. Replaced direct socket operations with service-based interactions for better modularity and maintainability. Updated hooks and context to align with the new architecture. - Removed useChatroomCore in favor of useChatroomService - Updated SocketProvider to manage socket connection via SocketService - Ensured backward compatibility by keeping raw socket references
|
4 tasks
|
✅ Knip Scan Result for 916d804 |
|
🤖 Lighthouse Scan Result for 916d804 /rooms
/rooms/abc
/login
|
|
Looks great! I'll test it out when I have time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why need this change?:
This PR refactors the chatroom-related components to adopt the new SocketService architecture, improving modularity and maintainability.
Changes made:
useChatroomCorewithuseChatroomService.SocketService.SocketServicemethods.Test Scope / Change impact:
This refactor makes it easier to extend and manage WebSocket connections while reducing direct socket dependencies across the codebase.
Issue