Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(newserver): Trackmania Nations/United Forever #4184

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

h3o66
Copy link
Member

@h3o66 h3o66 commented Apr 10, 2023

Description

Add server for Trackmania Nations/United Forever

Fixes #1444

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (a change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked if documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@Hornochs
Copy link
Contributor

@dgibbs64 I know It's a really old PR and seeing you did something with it. Is there anything that can be done to make it doable for main? Would be awesome to have this game supported as well :)

@h3o66
Copy link
Member Author

h3o66 commented Sep 13, 2024

@dgibbs64 I know It's a really old PR and seeing you did something with it. Is there anything that can be done to make it doable for main? Would be awesome to have this game supported as well :)

I would need to rebase this one, that was only a idea at that time to integrate that one :)

@Hornochs
Copy link
Contributor

I would need to rebase this one, that was only a idea at that time to integrate that one :)

Would be cool 🤗. Seeing TMNF as supported game as well😊

@h3o66 h3o66 force-pushed the feature/trackmania-nations-forever branch from a427e5e to 1e10345 Compare September 15, 2024 15:46
@Hornochs
Copy link
Contributor

Thanks for the rebase 😍

@h3o66
Copy link
Member Author

h3o66 commented Sep 15, 2024

Thanks for the rebase 😍

A few things are probably still todo:

  • parse the config for the servername , ports , password and maybe a few other things
  • make a doc page to note down how to create a account for United Forever / Nations Forever ( afaik you need a account to have the server visible in the serverlist )

Not sure if anything else left, but at least the inital install should work.

@Hornochs
Copy link
Contributor

A few things are probably still todo:

  • parse the config for the servername , ports , password and maybe a few other things

That’s the Ding that failed for my PR on Xonotic as well 🥲. The .cfg File is in XML. That should make parsing doable. I‘ll write the necessary ports / parts shortly.

  • make a doc page to note down how to create a account for United Forever / Nations Forever ( afaik you need a account to have the server visible in the serverlist )

I‘m not sure if the master server still exist. The website from Nadeo, on creating an account is offline. I‘ll test if you‘re still able to create an account ingame.

Not sure if anything else left, but at least the inital install should work.

We’ll write down in the documentation about XML-RPC to make the server queryable.

@h3o66 h3o66 force-pushed the feature/trackmania-nations-forever branch from 1e10345 to 0e96259 Compare September 15, 2024 19:51
@h3o66
Copy link
Member Author

h3o66 commented Sep 15, 2024

That’s the Ding that failed for my PR on Xonotic as well 🥲. The .cfg File is in XML. That should make parsing doable. I‘ll write the necessary ports / parts shortly.

there are newer functions to parse the config easy.

I added now some base parsing for the config , in this case for this xml config paths:

/dedicated/server_options/name
/dedicated/server_options/max_players
/dedicated/server_options/password
/dedicated/system_config/server_port
/dedicated/system_config/xmlrpc_port

@Hornochs
Copy link
Contributor

@h3o66 this PR is still a draft. Could make it now open so @dgibbs64 could check it and merge it? 😊

@h3o66
Copy link
Member Author

h3o66 commented Sep 20, 2024

@h3o66 this PR is still a draft. Could make it now open so @dgibbs64 could check it and merge it? 😊

yeah, this is still a draft as the login for the online server is madatory.
So some howto needs to be written before i will change it from draft to ready for review.

@h3o66 h3o66 mentioned this pull request Sep 23, 2024
2 tasks
@Hornochs
Copy link
Contributor

…the online server is madatory. So some howto needs to be written before i will change it from draft to ready for review.

After some digging I found that the webpage, that was open for creating an Trackmania account has changed.

After finding this tutorial I guess I found a promising source of documentation. Seems like the old trackmania accounts got migrated to Ubisoft accounts etc.

So yes, the documentation is necessary, I’ll start it and should be ready in 1-2 weeks. Will then search deeper on how to enable United for people who bought the game.

@h3o66
Copy link
Member Author

h3o66 commented Sep 27, 2024

…the online server is madatory. So some howto needs to be written before i will change it from draft to ready for review.

After some digging I found that the webpage, that was open for creating an Trackmania account has changed.

After finding this tutorial I guess I found a promising source of documentation. Seems like the old trackmania accounts got migrated to Ubisoft accounts etc.

So yes, the documentation is necessary, I’ll start it and should be ready in 1-2 weeks. Will then search deeper on how to enable United for people who bought the game.

That howto looks like tm2020 to me , the files are to new for that, see the first after starting the server.

@Hornochs
Copy link
Contributor

Hornochs commented Sep 28, 2024

The Server files Are for 2020, thats true. But i suppose that the „Server Accounts“ Are also for TMNF There.

@Hornochs
Copy link
Contributor

@h3o66 You were right, the Server accounts are for TM2020.

Written in https://www.gamers.org/tmf/quickstart.html it says the the Account needs to be created for the free Version (Nations Forever) you need to use the GameClient for creating an account and for the paid version (United Forever) you need to create a seperate login on http://official.trackmania.com/tmf-playerpage/ ... ITs either http or not supported https ...

@Hornochs
Copy link
Contributor

@h3o66 I wrote the Documentation for TMNF / TMUF in regards of dedicated server hosting. PR is open. You can see in my branch whats written down. IMHO that should be enough information about hosting a server.

@h3o66
Copy link
Member Author

h3o66 commented Sep 28, 2024

@h3o66 I wrote the Documentation for TMNF / TMUF in regards of dedicated server hosting. PR is open. You can see in my branch whats written down. IMHO that should be enough information about hosting a server.

commented there - thanks :)

@h3o66 h3o66 force-pushed the feature/trackmania-nations-forever branch from 0e96259 to 636d08d Compare September 28, 2024 14:49
@h3o66
Copy link
Member Author

h3o66 commented Sep 28, 2024

Thanks for the rebase 😍

A few things are probably still todo:

  • parse the config for the servername , ports , password and maybe a few other things
  • make a doc page to note down how to create a account for United Forever / Nations Forever ( afaik you need a account to have the server visible in the serverlist )

Not sure if anything else left, but at least the inital install should work.

Did another rebase with the lastest 2 releases (release, hotfix and new stuff to the dev branch).

TODO:

  • setup one time a online server and test
  • port info for the details command
  • check query function or how it can be used ( online check and gamedig config for the game )

@Hornochs
Copy link
Contributor

  • check query function or how it can be used ( online check and gamedig config for the game )

GameDig Supports Nadeo Game but got an bug at the moment

@h3o66
Copy link
Member Author

h3o66 commented Sep 28, 2024

  • check query function or how it can be used ( online check and gamedig config for the game )

GameDig Supports Nadeo Game but got an bug at the moment

well , bad, need to see what i can do then - maybe i can hack the local installed gamedig to work at least.

@Hornochs
Copy link
Contributor

  • check query function or how it can be used ( online check and gamedig config for the game )

GameDig Supports Nadeo Game but got an bug at the moment

well , bad, need to see what i can do then - maybe i can hack the local installed gamedig to work at least.

Yep, the querying of map data failes, not sure if it’s an bug in GameDig or the XMLRPC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: game server request Request for a new server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants