Introduce wp.org plugin-guidelines check action #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[pull] main from GatherPress:main
…t the standards for the WordPress.org plugin directory
|
The test is running and correctly complaining about some stuff. My last two commits, where not needed by the PR itself, but to make sure the test is recognizing changes. Now there is one thing left, I'm unsure about. Please, @mauteri could you have a look at this screenshot. What is the problem with the custom table during the action runs?
|
carstingaxion
changed the title
|
Sure, I'll take a look. Thx! |
mauteri
reviewed
Mar 20, 2024
(and renamed the workflow file;)
2 tasks
carstingaxion
added a commit
to figuren-theater/label-printing
that referenced
this pull request
May 29, 2024
With the set goal in mind to become a versatile community plugin, _label-printing_ > [...] should at **every time** align with the .org/plugin review standards, at least with the automated part of the review process. > > This is where the [Plugin Check (PCP)](https://wordpress.org/plugins/plugin-check/) WordPress plugin comes into play, because thankfully there is also a [corresponding github action](https://github.com/swissspidy/wp-plugin-check-action). > ### Description of the Change > > [...] we should introduce this action into our default `push` and `pull_request` workflows. This would also be a nice aspect to promote further, saying "We align with the guidelines not only once (like normal), but with every release". > > ~Closes #~ Closes #46 > ### How to test the Change > > I hope to see the test running within this PR, to get a basic testing. > ### Changelog Entry > > > Added - Test against standards for the WordPress.org plugin directory --- Cloned PR from GatherPress/gatherpress#616 --- ### Code Checklist - [x] tested - [ ] documented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the set goal in mind to become a versatile community plugin within the WordPress sphere, GatherPress should at every time align with the .org/plugin review standards, at least with the automated part of the review process.
This is where the Plugin Check (PCP) WordPress plugin comes into play, because thankfully there is also a corresponding github action.
Description of the Change
After the overwhelming feedback we got from the WordPress plugin review team we should introduce this action into our default
pushandpull_requestworkflows. This would also be a nice aspect to promote further, saying "We align with the guidelines not only once (like normal), but with every release".Closes #How to test the Change
I hope to see the test running within this PR, to get a basic testing.
Changelog Entry
Credits
Props @carstingaxion
Checklist: