Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new unit tests, small code changes. #895

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

mauteri
Copy link
Contributor

@mauteri mauteri commented Sep 20, 2024

Description of the Change

Closes #

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @username, @username2, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

Copy link

Preview changes with Playground

You can preview the recent changes for PR#895 with the following PHP versions:

PHP Version 8.3

PHP Version 7.4

Download .zip with build changes

Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions.

@mauteri mauteri merged commit 010d16b into main Sep 20, 2024
13 checks passed
@mauteri mauteri deleted the mauteri-unit-test-2 branch September 20, 2024 21:04
@carstingaxion
Copy link
Collaborator

He @mauteri could you give me a short explainer, why you removed the context from the sanitize_title() call. Aren't we going to save this string?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants