Prepare for new block variations 3/3: block variation loading #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
carstingaxion
changed the title
mauteri
requested changes
Oct 12, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
Preview changes with PlaygroundYou can preview the recent changes for PR#898 with the following PHP versions: PHP Version 8.3
PHP Version 7.4
Download Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions. |
mauteri
approved these changes
Oct 17, 2024
|
Woooow! That was super fast again, @mauteri |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation to bring some block variations from the gatherpress-block-playground into the plugin as part of #626.
While current blocks can rely on
register_block_type()to get everything in place, block variations need more manual attention.Description of the Change
With this PR, I try to outline a possible way to load all variations the same way.
Because most of the variations need some extra php to work, I went with a singleton, that gets automatically ...
copied from/srcto/buildand lives in the folder of the variation. For this reason the autoloader doesn’t know about the classes and that’s why I required them manually... loaded from
includes/core/classes/blocks.This design-decision was made in a private chat between @mauteri and me.
Closes #How to test the Change
Changelog Entry
Credits
Props @carstingaxion, @mauteri
Checklist: