Add menu with popper example #95
Conversation
| <div class='flex justify-center w-screen h-full p-12 bg-gray-50'> |
There was a problem hiding this comment.
this is menu/basic, but with PopperJS
I think it's fine for us to make breaking changes like this 👍 FYI, it looks like there are some failing tests in CI |
|
excellent! because ember-auto-import@v2 is a requirement for ember 4 :D |
|
I'm not sure how any of these were passing 🤔 I assume most of this was copied from either the React or Vue repo? |
|
It seems back when we were on webpack 4 (ember-auto-import@v1, a bunch of implicit non-browser behaviors were getting polyfilled) |
|
|
||
| return; | ||
| } | ||
| switch (options.state) { |
There was a problem hiding this comment.
best to view this file without invisible character changes
| } | ||
| } catch (err) { | ||
| Error.captureStackTrace(err, assertDialog); |
There was a problem hiding this comment.
captureStackTrace is a node-only API
|
I'm totally fine with making a breaking change and upgrading to In this PR at least, it seems that |
|
FYI, I've updated |
This is a breaking change, so if ya'll don't want to go along with this, that's fine by me.
the breaking change is that any consuming project must also be using ember-auto-import@v2
The demo is the same as the "Basic" Menu demo, and is only has noticeable differences on super small screens where popper starts to take control of positioning as layout constraints come in to play