-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imposed master branch #348
Conversation
Irrespective of a defaultBranch definition in file .gitconfig, the edit allows to pass a commit to be accepted. Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Contrasting to the previous version, the name of the principal branch is explicitly defined. The description of the task ahead is lightly edited. Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Explicit definition of the principal branch as master, and a light edit of the description of the task ahead. Signed-off-by: Norwid Behrnd <[email protected]>
Explicitly define the principal branch as master. Light edit of the description of the task ahead and of the hint about the solution. Signed-off-by: Norwid Behrnd <[email protected]>
Explicitly define the principal branch as master. Light edit of the description of the task ahead, light lint of the source code. Signed-off-by: Norwid Behrnd <[email protected]>
Explicitly define the principal branch as master. Light edit of the description about the task ahead. Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Explicitly define the principal branch as master. Light edit of the description of the task ahead. Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
Signed-off-by: Norwid Behrnd <[email protected]>
This looks good. I was initially curious as to why this wasn't in By the way, for the stage_lines level, you want to use |
«Hunk editing» is a thing I'm not yet confident in; thus the particular note to have the corresponding quiz be checked by someone who is. One incentive for me to see Eventually, the slight modification by the lines of grit which currently is used as interface between Ruby and grit is stated as no longer maintained (ref). A transition to libgit2/rugged (entry on rubygems) hence might be a next leap to consider for the over next version of githug i.e., 0.7.0. An increased visibility of |
I haven't forgotten about this btw. It looks good, I just need to confirm about the push level. I think it should be fine just looking at the code and tests, but need to double check. |
The work wasn't done in a single session (there are a few commits to adjust
the same .rb file again a couple of days later once again, too). Backed by
this experience, I easily understand the review will take some time.
|
Thanks so much for this <3 |
@Gazler Where deemed suitable, I added a line
system "git branch -m master"
and lightly edited the description of the tasks in levels 2 up and including 55. As a result, the locally build rubygem and its locally installed executable works regardless that my~/.gitconfig
includes an entry ofCan you please have a look on this? To ease the revision by a second party, edits to each level are intentionally retained in its own commit.
Level 28/push however is somewhat odd. Because I can run
though the commits just prior to the
push
likely are not in the sequence the initial design of this question aims for. I would accept if I'm wrong on this point.I'm not yet comfortable to test the quizz of level 50 /
stage_lines
; however, because this is a git technique so far not used. It is a bit beyond resolving merge conflicts I usually resolve withgit mergetool
.