Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hashing based caching for mechanism compilation #73

Merged
merged 8 commits into from
Jan 12, 2024
Merged

Use hashing based caching for mechanism compilation #73

merged 8 commits into from
Jan 12, 2024

Conversation

frthjf
Copy link
Collaborator

@frthjf frthjf commented Dec 11, 2023

This addresses several shortcomings of the previous implementation

  • use a hash-named directory for automatic recompilation when source changes
  • invalidate results if compilation fails
  • make the output path configurable (since likely $SCRATCH or similar)
  • make MPI communicator configurable (including no MPI use)

@frthjf frthjf requested a review from iraikov December 11, 2023 05:13
skim0119
skim0119 approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@skim0119 skim0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frthjf frthjf merged commit 76723e0 into main Jan 12, 2024
9 checks passed
@frthjf frthjf deleted the feature/mechanism-handling branch January 12, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skim0119 skim0119 skim0119 approved these changes

@iraikov iraikov Awaiting requested review from iraikov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frthjf @skim0119