Rod sphere contact #298
Rod sphere contact #298
Conversation
|
Changes in examples/Binder have been repeated from #294 since this formatting has not been done in the update-0.3.2 branch. These changes are done by auto-formatting while committing. |
Codecov ReportPatch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
📢 Thoughts on this report? Let us know!. |
Rahul-JOON
requested review from
armantekinalp,
bhosale2 and
skim0119
as code owners
Ali-7800
added
enhancement
|
@Rahul-JOON Can you add tests for the RodSphereContact class? Otherwise looks good to me just some minor comments |
elastica/contact_forces.py
Outdated
| x_sph, | ||
| system_two.radius * system_two.director_collection[2, :, 0], | ||
| system_one.radius + system_two.radius, | ||
| system_one.lengths + system_two.lengths, |
There was a problem hiding this comment.
Length doesn't make much sense of sphere, and it is set as length = 2*radius. Maybe here we replace with following
| system_one.lengths + system_two.lengths, | |
| system_one.lengths + 2 * system_two.radius, |
There was a problem hiding this comment.
@Ali-7800 what do you think?
There was a problem hiding this comment.
I agree, maybe we should remove it later too cause it only makes sense for cylinders.
| system_two.position_collection[..., 0] | ||
| - system_two.radius * system_two.director_collection[2, :, 0] | ||
| system_two.position[..., 0] | ||
| - system_two.radius * system_two.director[2, :, 0] |
| x_sph, | ||
| system_two.radius * system_two.director_collection[2, :, 0], | ||
| system_two.radius * system_two.director[2, :, 0], |
| system_one.internal_forces, | ||
| system_one.external_forces, | ||
| system_two.external_forces, | ||
| system_two.external_torques, | ||
| system_two.director_collection[:, :, 0], | ||
| system_two.director[:, :, 0], |
| system_two.position_collection, | ||
| system_two.director_collection, | ||
| system_two.radius[0], | ||
| system_two.position, |
There was a problem hiding this comment.
It was correct before why did you change it?
armantekinalp
changed the base branch from
update-0.3.2
to
266_Rod_and_Sphere_Contact_temp
This PR attempts to add Rod SPhere contact functionality as per #266.