Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RodPlaneContact and RodPlaneContactWithAnisotropicFriction Classes #314

Merged
merged 1 commit into from
Oct 30, 2023
Merged

RodPlaneContact and RodPlaneContactWithAnisotropicFriction Classes #314

merged 1 commit into from
Oct 30, 2023

Conversation

Ali-7800
Copy link
Collaborator

Fourth contact module PR mentioned in Issue
This PR includes:

  • Added RodPlaneContact, and RodPlaneContactWithFriction which are based on InteractionPlane and AnisotropicFrictionalPlane from interaction.
  • Updated base_system to call _call_contacts last (needed so the external forces are applied before contact)
  • Updated memory_block to accept surface class when appended to the simulation

@Ali-7800 Ali-7800 self-assigned this Oct 27, 2023
@Ali-7800 Ali-7800 requested review from sy-cui and removed request for bhosale2 October 27, 2023 21:51
@Ali-7800 Ali-7800 added enhancement New feature or request prio:medium Priority level: medium labels Oct 27, 2023
@Ali-7800 Ali-7800 added this to the Version 0.3.2 milestone Oct 27, 2023
sy-cui
sy-cui reviewed Oct 27, 2023
View reviewed changes
Copy link
Contributor

@sy-cui sy-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the additions are the functions from the interaction file (unless there are minor differences that I didn't catch?). Should the old ones be removed if we are moving them here?

elastica/contact_forces.py Show resolved Hide resolved
elastica/contact_utils.py Show resolved Hide resolved
sy-cui
sy-cui approved these changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@sy-cui sy-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The contact forces file seems a bit overcrowded. Maybe in a future update separate them into different locations.

armantekinalp
armantekinalp approved these changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @Ali-7800 please also start refactoring PR for interaction right after this PR.

@Ali-7800 Ali-7800 merged commit 337ecba into GazzolaLab:update-0.3.2 Oct 30, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armantekinalp armantekinalp armantekinalp approved these changes

@sy-cui sy-cui sy-cui approved these changes

@skim0119 skim0119 Awaiting requested review from skim0119

Assignees

@Ali-7800 Ali-7800

Labels
enhancement New feature or request prio:medium Priority level: medium
Projects
None yet
Milestone
Version 0.3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Ali-7800 @sy-cui @armantekinalp