Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring contact functions + tests #316

Merged
merged 8 commits into from
Nov 7, 2023

Conversation

Ali-7800
Copy link
Collaborator

Fifth contact module PR mentioned in Issue
This PR includes:

  • Refactored contact functions in joint.py and interaction.py
  • Updated test_joint.py and interaction.py accordingly
  • Moved contact force calculation functions from contact_forces.py into _contact_functions.py
  • Moved tests in test_common_contact_function.py,test_specific_contact_function.py, and test_contact_wrapper_classes.py into joint.py
  • Added tests related to rod-plane contact in test_contact_utils.py,test_contact_functions.py, and test_contact_classes.py

@Ali-7800 Ali-7800 self-assigned this Oct 31, 2023
@Ali-7800 Ali-7800 requested review from sy-cui and removed request for bhosale2 October 31, 2023 02:10
@Ali-7800 Ali-7800 added this to the Version 0.3.2 milestone Oct 31, 2023
@Ali-7800 Ali-7800 added enhancement New feature or request prio:medium Priority level: medium refactor Refactor existing features labels Oct 31, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
elastica/contact_forces.py 91.01% <ø> (+29.51%) ⬆️
elastica/joint.py 96.90% <100.00%> (+11.05%) ⬆️
elastica/interaction.py 76.04% <81.81%> (-12.97%) ⬇️
elastica/_contact_functions.py 82.99% <82.99%> (ø)

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@sy-cui sy-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As a next step lets refactor examples that uses contact functions and friction and do a PR right after this.

Copy link
Collaborator

@skim0119 skim0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ali-7800 Ali-7800 merged commit 1da4dbc into GazzolaLab:update-0.3.2 Nov 7, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prio:medium Priority level: medium refactor Refactor existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants