-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring contact functions + tests #316
Conversation
…_contact_functions.py to make it less croweded
…s in contact_utils.py and _contact_functions.py
Codecov ReportAttention: ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. As a next step lets refactor examples that uses contact functions and friction and do a PR right after this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Fifth contact module PR mentioned in Issue
This PR includes:
joint.py
andinteraction.py
test_joint.py
andinteraction.py
accordinglycontact_forces.py
into_contact_functions.py
test_common_contact_function.py
,test_specific_contact_function.py
, andtest_contact_wrapper_classes.py
intojoint.py
test_contact_utils.py
,test_contact_functions.py
, andtest_contact_classes.py