Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact Module Documentation #331

Merged
merged 6 commits into from
Feb 20, 2024
Merged

Conversation

Ali-7800
Copy link
Collaborator

@Ali-7800 Ali-7800 commented Feb 13, 2024

Last contact module PR mentioned in Issue
This PR includes:

@Ali-7800 Ali-7800 added the enhancement New feature or request label Feb 13, 2024
@Ali-7800 Ali-7800 added this to the Version 0.3.2 milestone Feb 13, 2024
@Ali-7800 Ali-7800 self-assigned this Feb 13, 2024
@Ali-7800 Ali-7800 requested a review from bhosale2 as a code owner February 13, 2024 23:04
@Ali-7800 Ali-7800 removed the request for review from bhosale2 February 13, 2024 23:05
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1bf7fca) 94.01% compared to head (7e4b80f) 94.00%.

❗ Current head 7e4b80f differs from pull request most recent head efd98ef. Consider uploading reports for the commit efd98ef to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           update-0.3.2     #331      +/-   ##
================================================
- Coverage         94.01%   94.00%   -0.01%     
================================================
  Files                51       51              
  Lines              3172     3170       -2     
  Branches            347      347              
================================================
- Hits               2982     2980       -2     
  Misses              140      140              
  Partials             50       50              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skim0119
Copy link
Collaborator

Push to doc_patch branch

@skim0119 skim0119 changed the base branch from update-0.3.2 to doc_patch February 15, 2024 19:49
@armantekinalp
Copy link
Contributor

@skim0119 can you lgtm

Copy link
Collaborator

@skim0119 skim0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@skim0119 skim0119 merged commit d12107a into GazzolaLab:doc_patch Feb 20, 2024
12 checks passed
@Ali-7800 Ali-7800 deleted the 113_dev_contact branch February 25, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants