Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

282 Binder not working with Poetry issue #340

Merged
merged 14 commits into from
Mar 9, 2024

Conversation

Ali-7800
Copy link
Collaborator

@Ali-7800 Ali-7800 commented Mar 7, 2024

Fixes issue #282, added a pip install at the beginning of notebooks to install dependencies.

@Ali-7800 Ali-7800 added bug Something isn't working prio:high Priority level: high labels Mar 7, 2024
@Ali-7800 Ali-7800 added this to the Version 0.3.2 milestone Mar 7, 2024
@Ali-7800 Ali-7800 requested a review from skim0119 March 7, 2024 21:56
@Ali-7800 Ali-7800 self-assigned this Mar 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.01%. Comparing base (c55677b) to head (2b1034e).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##           update-0.3.2     #340   +/-   ##
=============================================
  Coverage         94.01%   94.01%           
=============================================
  Files                51       51           
  Lines              3172     3172           
  Branches            347      347           
=============================================
  Hits               2982     2982           
  Misses              140      140           
  Partials             50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ali-7800 Ali-7800 removed the request for review from bhosale2 March 8, 2024 21:44
Copy link
Collaborator

@skim0119 skim0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skim0119 skim0119 merged commit f582749 into GazzolaLab:update-0.3.2 Mar 9, 2024
10 checks passed
@skim0119
Copy link
Collaborator

skim0119 commented Mar 9, 2024

@Ali-7800 I rebased the branch before merge. Please delete your branch Ali-7800:282_dev_binder_poetry.

@Ali-7800 Ali-7800 deleted the 282_dev_binder_poetry branch March 10, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prio:high Priority level: high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants