Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deployment of infrastructure through Terraform #47

Merged
merged 17 commits into from
Dec 10, 2023
Merged

Conversation

giulio-giunta
Copy link
Contributor

Terraform was failing due to some outdated parameters. In order to fix it, I had to update those parameters and pinned the "azurerm" provider version to avoid sudden disruption in the future.

Description

Pinned the "azurerm" provider version

Related Issue

#46 "

Motivation and Context

The change was needed to enable Terraform to build the infrastructure.

How Has This Been Tested?

It was tested by running terraform plan.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@giulio-giunta giulio-giunta self-assigned this May 28, 2023
@giulio-giunta
Copy link
Contributor Author

Terraform is now able to deploy the AKS cluster, as shown in the screenshot below.

Screenshot_2023-09-24_13-32-07

@giulio-giunta giulio-giunta changed the title Pinned azurerm provider to specific version and adjusted parameters in AKS module Fix deployment of infrastructure through Terraform Sep 24, 2023
@giulio-giunta
Copy link
Contributor Author

Hi @jamesgeddes,
Can you please review this PR?
Terraform is now able to spin the cluster as shown in PR #698 in the "web" repo.

Copy link

sonarcloud bot commented Dec 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@jamesgeddes jamesgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@giulio-giunta giulio-giunta merged commit c09fe35 into main Dec 10, 2023
17 checks passed
@giulio-giunta giulio-giunta deleted the feature-46 branch December 10, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants