Ref #10: tune API for /machines

Gelassen · Feb 27, 2024 · 4c11613 · 4c11613
1 parent ecd2edf
commit 4c11613
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 11 deletions.
diff --git a/...nd/src/main/kotlin/io/github/gelassen/manufactory_knowledge_management/HttpControllers.kt b/...nd/src/main/kotlin/io/github/gelassen/manufactory_knowledge_management/HttpControllers.kt
@@ -4,6 +4,7 @@ import org.springframework.http.HttpStatus
 import org.springframework.web.bind.annotation.GetMapping
 import org.springframework.web.bind.annotation.PathVariable
 import org.springframework.web.bind.annotation.RequestMapping
+import org.springframework.web.bind.annotation.RequestParam
 import org.springframework.web.bind.annotation.RestController
 import org.springframework.web.server.ResponseStatusException
 
@@ -13,8 +14,8 @@ class MachineController(
     private val repository: MachinesRepository
 ) {
 
-    @GetMapping("/barcode/{barcode}")
-    fun getMachineByBarcode(@PathVariable barcode: String) =
+    @GetMapping
+    fun getMachineByBarcode(@RequestParam barcode: String) =
         repository.findMachineByBarcode(barcode) ?: throw ResponseStatusException(
             HttpStatus.NOT_FOUND,
             "Machine with $barcode barcode does not exist. Did you send the right barcode?"

diff --git a/...c/main/kotlin/io/github/gelassen/manufactory_knowledge_management/ProjectConfiguration.kt b/...c/main/kotlin/io/github/gelassen/manufactory_knowledge_management/ProjectConfiguration.kt
@@ -10,14 +10,7 @@ class ProjectConfiguration {
 
     @Bean
     fun databaseInitializer(machineRepository: MachinesRepository) = ApplicationRunner {
-        var sodickSaved = machineRepository.save(
-            Machine(
-                name = "Sodick 360b",
-                manufacturer = "Sodick",
-                barcode = "Sodick 360b"
-            )
-        )
-/*        var sodickSaved = machineRepository.save(Machine(
+        var sodickSaved = machineRepository.save(Machine(
                 name = "Sodick 360b",
                 manufacturer = "Sodick",
                 barcode = "Sodick 360b"
@@ -27,6 +20,6 @@ class ProjectConfiguration {
             name = "Fanuc 2000",
             manufacturer = "Fanuc",
             barcode = "Fanuc 2000")
-        )*/
+        )
     }
 }