chore: run clang-tidy (linter) on all files when on main or manually triggered #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
permissions:
packages: read
Comment on lines
+14
to
+23
| waitForDependencyImage: | ||
| name: Wait for Docker Image | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Wait for Docker Image | ||
| uses: lewagon/[email protected] | ||
| with: | ||
| ref: ${{ github.ref }} | ||
| repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
| check-name: Build linter dependencies |
There was a problem hiding this comment.
Do we need this job?
on:
workflow_run:
workflows: [Build Linter Image]
should already do the waiting.
There was a problem hiding this comment.
True. I did not know you can still define branch as a condition. But this does not work for the diffed files unfortunately as I need the PR number in the action to get the list of changed files. And I can only get it in the PR trigger event
Comment on lines
+36
to
+55
| - shell: bash | ||
| name: Configure and run clang-tidy on changed files | ||
| run: | | ||
| mv /src/build . | ||
| cmake -DBUILD_WITH_CLANG_TIDY=on -D CMAKE_BUILD_TYPE=Debug -B build | ||
| echo "Successfully configured cmake" | ||
| files=$(curl -s \ | ||
| "https://api.github.com/repos/${{ github.repository }}/pulls/${PR_NUMBER}/files" \ | ||
| | jq -r '.[].filename') | ||
| echo "Changed files of this PR:" | ||
| echo "$files" | ||
| IFS=$'\n' | ||
| for file in $files; do | ||
| echo "Check ending for file: $file" | ||
| if [[ $file == *.cpp ]]; then | ||
| echo "Now linting the file: $file" | ||
| echo "cmake --build build --target ${file%.cpp}.o" | ||
| cmake --build build --target ${file%.cpp}.o | ||
| fi | ||
| done |
There was a problem hiding this comment.
Can't we simply use the old approach when running the linter on all files (i.e. simply building the code)?
There was a problem hiding this comment.
Ah, yes, that was supposed to be the case. I was still experimenting with the action triggers and waits! Sorry for not marking it as draft!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #498
Summary
PR Checklist