Linter revert version to clang-15 #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taepper
force-pushed
the
linter-revert-version
branch
from
b4c4840
to
143226f
Compare
|
There is no change in the changelog. This PR will not produce a new releasable version. |
Taepper
force-pushed
the
linter-revert-version
branch
from
143226f
to
db2216c
Compare
| @@ -7,7 +7,7 @@ RUN apt update \ | |||
| cmake python3-pip software-properties-common wget gnupg lsb-release \ | |||
| && wget -qO- https://apt.llvm.org/llvm-snapshot.gpg.key | tee /etc/apt/trusted.gpg.d/apt.llvm.org.asc \ | |||
| && add-apt-repository 'deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy main' \ | |||
| && apt install -y clang-tidy-20 \ | |||
| && apt install -y clang-tidy-15 \ | |||
There was a problem hiding this comment.
Is clang tidy 15 the only version that works right now? I think I remember that we had 17 for a while, and before we upgraded to 20, we had 19.
There was a problem hiding this comment.
15 is the most recent non-current version that is installable from that external package source. We can could also change the source to another?
There was a problem hiding this comment.
Hm, did that change? Maybe they removed the clang-19 package? Or why was it installable before?
There was a problem hiding this comment.
Yes, not all versions will be maintained. See current installation attempts:
root@063f836181fc:/# apt install clang-tidy-19
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
E: Unable to locate package clang-tidy-19
root@063f836181fc:/# apt install clang-tidy-18
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
E: Unable to locate package clang-tidy-18
root@063f836181fc:/# apt install clang-tidy-17
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
E: Unable to locate package clang-tidy-17
root@063f836181fc:/# apt install clang-tidy-16
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
E: Unable to locate package clang-tidy-16
root@063f836181fc:/# apt install clang-tidy-15
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following additional packages will be installed:
clang-15 clang-tools-15 icu-devtools lib32gcc-s1 lib32stdc++6 libc6-i386 libclang-common-15-dev libclang-cpp15 libclang1-15 libedit2
libffi-dev libgc1 libicu-dev libllvm15 libncurses-dev libobjc-11-dev libobjc4 libpfm4 libtinfo-dev libxml2-dev libz3-4 libz3-dev llvm-15
llvm-15-dev llvm-15-linker-tools llvm-15-runtime llvm-15-tools python3-pygments python3-yaml
Suggested packages:
clang-15-doc wasi-libc icu-doc ncurses-doc pkg-config llvm-15-doc python-pygments-doc ttf-bitstream-vera
The following NEW packages will be installed:
clang-15 clang-tidy-15 clang-tools-15 icu-devtools lib32gcc-s1 lib32stdc++6 libc6-i386 libclang-common-15-dev libclang-cpp15 libclang1-15
libedit2 libffi-dev libgc1 libicu-dev libllvm15 libncurses-dev libobjc-11-dev libobjc4 libpfm4 libtinfo-dev libxml2-dev libz3-4 libz3-dev
llvm-15 llvm-15-dev llvm-15-linker-tools llvm-15-runtime llvm-15-tools python3-pygments python3-yaml
fengelniederhammer
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test PR for now, whether a revert to clang-tidy-15 (using clang-15) will make the CI green again
PR Checklist