Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build arm images on demand #676

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Build arm images on demand #676

merged 2 commits into from
Jan 27, 2025

Conversation

Taepper
Copy link
Collaborator

@Taepper Taepper commented Jan 14, 2025

Summary

When testing builds, it can be beneficial, to also have the arm images ready to test in PRs. This is not possible currently, because we only build these images on merges main, as github's arm emulation is quite time-consuming. This PR adds the possibility to request an ARM image by adding the label arm-image to the PR

PR Checklist

- [ ] All necessary documentation has been adapted or there is an issue to do so.
- [ ] The implemented feature is covered by an appropriate test.

Copy link
Contributor

There is no change in the changelog. This PR will not produce a new releasable version.

@Taepper Taepper force-pushed the ondemand-arm-image branch from 3731152 to ea95fc6 Compare January 15, 2025 08:34
@Taepper Taepper marked this pull request as draft January 15, 2025 10:23
@Taepper Taepper force-pushed the ondemand-arm-image branch from 979db93 to 1907cc9 Compare January 15, 2025 19:28
@Taepper Taepper force-pushed the ondemand-arm-image branch from 3efd18d to 342bf07 Compare January 21, 2025 11:02
@Taepper Taepper marked this pull request as ready for review January 22, 2025 18:45
@Taepper Taepper force-pushed the ondemand-arm-image branch 2 times, most recently from 37184d4 to b9af620 Compare January 22, 2025 22:09
Copy link
Contributor

@fengelniederhammer fengelniederhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's try it 👍

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@Taepper Taepper force-pushed the ondemand-arm-image branch from b9af620 to 00bff9f Compare January 27, 2025 13:21
@Taepper
Copy link
Collaborator Author

Taepper commented Jan 27, 2025

Uhhh, the runner is now repeatedly running out of memory

@Taepper
Copy link
Collaborator Author

Taepper commented Jan 27, 2025

That was also the problem on the "alternate PR".. I think it is easier to fix here

@Taepper Taepper merged commit 528ff37 into main Jan 27, 2025
10 checks passed
@Taepper Taepper deleted the ondemand-arm-image branch January 27, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants