Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use clang-format 19 #687

Closed
wants to merge 1 commit into from
Closed

chore: use clang-format 19 #687

wants to merge 1 commit into from

Conversation

fengelniederhammer
Copy link
Contributor

@fengelniederhammer fengelniederhammer commented Jan 28, 2025

Summary

Clang-format 17 is not in the standard apt repository for Ubuntu.

The most recent version would be 20, but the format action that we use doesn't support it yet.

PR Checklist

- [ ] All necessary documentation has been adapted or there is an issue to do so.
- [ ] The implemented feature is covered by an appropriate test.

Copy link
Contributor

There is no change in the changelog. This PR will not produce a new releasable version.

@fengelniederhammer fengelniederhammer changed the title chore: use clang-format 20 chore: use clang-format 19 Jan 28, 2025
@fengelniederhammer
Copy link
Contributor Author

fengelniederhammer commented Jan 28, 2025

I'm acutally not sure whether clang 20 is officially released? I find their website confusing.

jidicula/clang-format-action doesn't support clang 20 yet. Ubuntu doesn't have clang-format 20 in its apt repo. I don't know whether this change is actually worth the trouble? Maybe we should just stay on 17?

@fengelniederhammer fengelniederhammer deleted the clangFormat20 branch January 29, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant