chore: use clang-format 19 #687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is no change in the changelog. This PR will not produce a new releasable version. |
fengelniederhammer
force-pushed
the
clangFormat20
branch
from
7939728 to
9946589
Compare
fengelniederhammer
changed the title
|
I'm acutally not sure whether clang 20 is officially released? I find their website confusing. jidicula/clang-format-action doesn't support clang 20 yet. Ubuntu doesn't have clang-format 20 in its apt repo. I don't know whether this change is actually worth the trouble? Maybe we should just stay on 17? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Clang-format 17 is not in the standard apt repository for Ubuntu.
The most recent version would be 20, but the format action that we use doesn't support it yet.
PR Checklist
- [ ] All necessary documentation has been adapted or there is an issue to do so.- [ ] The implemented feature is covered by an appropriate test.