Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lapis2): implement boolean columns #755

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

fengelniederhammer
Copy link
Contributor

@fengelniederhammer fengelniederhammer commented Apr 24, 2024

resolves #740

PR Checklist

@fengelniederhammer
Copy link
Contributor Author

I don't know what's wrong with the docs tests:

 E: Failed to fetch https://packages.microsoft.com/ubuntu/22.04/prod/dists/jammy/InRelease  Clearsigned file isn't valid, got 'NOSPLIT' (does the network require authentication?)
E: The repository 'https://packages.microsoft.com/ubuntu/22.04/prod jammy InRelease' is no longer signed.

Looks like some issue with Microsoft or GitHub.

@fengelniederhammer fengelniederhammer linked an issue Apr 24, 2024 that may be closed by this pull request
@fengelniederhammer fengelniederhammer force-pushed the 740-add-boolean-columns branch 2 times, most recently from 57e0691 to 751599e Compare April 24, 2024 10:04
Copy link
Contributor

@JonasKellerer JonasKellerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(It is not possible to enter null as a filter value in GET, but this should be targeted by #757
)

@fengelniederhammer
Copy link
Contributor Author

Also merging this on red docs tests since

  • this PR doesn't touch the docs
  • it seems to be infrastructure related

@fengelniederhammer fengelniederhammer merged commit 7718b4f into main Apr 24, 2024
10 of 11 checks passed
@fengelniederhammer fengelniederhammer deleted the 740-add-boolean-columns branch April 24, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add boolean columns
2 participants