Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lapis-docs): Sequence file naming scheme uses indexes now not names #958

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

tsibley
Copy link
Contributor

@tsibley tsibley commented Sep 24, 2024

The expected names of sequence files changed in LAPIS-SILO 0.2.13 from using names (e.g. nuc_main.fasta) to using indexes (nuc_0.fasta).

Related-to: GenSpectrum/LAPIS-SILO#529

The expected names of sequence files changed in LAPIS-SILO 0.2.13 from
using names (e.g. nuc_main.fasta) to using indexes (nuc_0.fasta).

Related-to: <GenSpectrum/LAPIS-SILO#529>
Copy link

vercel bot commented Sep 24, 2024

@tsibley is attempting to deploy a commit to the cov-spectrum Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@fengelniederhammer fengelniederhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

We know that the documentation is quite outdated, especially the parts regarding SILO. #376 contains a collection of issues we are aware of. (This issue was not on the list)

Also, we'd be glad to get feedback on the current docs. If something is not comprehensive enough or needs other improvements, just let us know.

@fengelniederhammer
Copy link
Contributor

Hm, our CI is not really prepared for PRs from forks... I'm merging anyways as I'm quite confident that this doesn't break anything ;)

@fengelniederhammer fengelniederhammer merged commit 1e7cd60 into GenSpectrum:main Sep 24, 2024
0 of 3 checks passed
@tsibley
Copy link
Contributor Author

tsibley commented Sep 24, 2024

@fengelniederhammer Thanks for the pointer to #376. I've found the current docs to be decent. While they might be outdated in places, they've still done a good job for me of helping paint the big picture (in combination with reading code/tests).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants