Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update psevents.dvc #8656

Closed
wants to merge 2 commits into from
Closed

Update psevents.dvc #8656

wants to merge 2 commits into from

Conversation

Esteban82
Copy link
Member

With the PR #8611, psevents.ps was modified. This PR updates the ps file.

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
deleted test/baseline/psevents/event_lines.ps
deleted test/baseline/psevents/eventlabelbox.ps
deleted test/baseline/psevents/events.ps
deleted test/baseline/psevents/lines.ps
deleted test/baseline/psevents/polygons.ps
deleted test/baseline/psevents/psevents_functions.ps
deleted test/baseline/psevents/varline.ps
modified test/baseline/psevents/

Image diff(s)

Added images

Modified images

Path Old New

Report last updated at commit 5f61e2b

@Esteban82
Copy link
Member Author

I followed the steps describe here:
https://docs.generic-mapping-tools.org/dev/devdocs/contributing.html#updating-reference-plots-for-tests

I am not sure if I did it well.

@Esteban82
Copy link
Member Author

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
deleted test/baseline/psevents/event_lines.ps
deleted test/baseline/psevents/eventlabelbox.ps
deleted test/baseline/psevents/events.ps
deleted test/baseline/psevents/lines.ps
deleted test/baseline/psevents/polygons.ps
deleted test/baseline/psevents/psevents_functions.ps
deleted test/baseline/psevents/varline.ps

I think I did it wrong (based on the deleted files here),

@joa-quim
Copy link
Member

joa-quim commented Jan 2, 2025

Probably 😄
I do that all the time. I'd love to find a replacement to DVC. It's only problems for many of us.

@seisman
Copy link
Member

seisman commented Jan 4, 2025

I don't see any failures with the psevents module in the master branch.

@remkos
Copy link
Contributor

remkos commented Jan 4, 2025

I am trying it again, without the #GMT_KNOWN_FAILURE

@remkos
Copy link
Contributor

remkos commented Jan 4, 2025

The tests keep failing, likely because of the deleted PS files.
@Esteban82: I suggest to start a new branch, but remember then first to upload the events.ps file to dvc.

It is possible that because of your #GMT_KNOWN_FAILURE the events.ps file was not generated, so you could not copy it. So leave that out.

$ dvc add test/baselines/psevents/events.ps
(this will also generate the appropriate psevents.dvc file)
$ dvc commit
$ dvc push

Then continue to commit and push to git as well.

@remkos remkos closed this Jan 4, 2025
@Esteban82
Copy link
Member Author

Thanks @remkos. I will make a new pull request following your comments.

@Esteban82 Esteban82 deleted the Update-psevents.dvc branch January 7, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants