Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clib.conversion: Remove the array_to_datetime function, which is no longer needed #3507

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

clib.conversion: Remove the array_to_datetime function, which is no longer needed #3507

wants to merge 26 commits into from

Commits on Oct 13, 2024

  1. Refactor vectors_to_arrays and deprecate the array_to_datetime function

    @seisman
    seisman committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    3661e54 View commit details
    Browse the repository at this point in the history

  2. No need to use pd.api.types.is_string_dtype anymore

    @seisman
    seisman committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    20b9215 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Add tests for vectors_to_arrays

    @seisman
    seisman committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    83673cf View commit details
    Browse the repository at this point in the history

  2. Rename test_clib_conversion.py to test_clib_vectors_to_arrays.py

    @seisman
    seisman committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    56a0841 View commit details
    Browse the repository at this point in the history

  3. Add one line of code back

    @seisman
    seisman committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    6338cde View commit details
    Browse the repository at this point in the history

  4. Explicitly checking array.dtype.type

    @seisman
    seisman committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    1864556 View commit details
    Browse the repository at this point in the history

  5. Correctly skip the tests if pyarrow is not installed

    @seisman
    seisman committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    54160bf View commit details
    Browse the repository at this point in the history

  6. Explicitly specify how to convert pandas/pyarrow string dtype to nump… 

    …y string dtype
    @seisman
    seisman committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    f4e1a5f View commit details
    Browse the repository at this point in the history

  7. Ensure the resulting numpy dtypes are supported by GMT

    @seisman
    seisman committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    ed3be20 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Merge branch 'main' into remove/array-to-datetime

    @seisman
    seisman committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    8ab6c6c View commit details
    Browse the repository at this point in the history

  2. Revert any changes that enhances the conversion process

    @seisman
    seisman committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    e26afbf View commit details
    Browse the repository at this point in the history

  3. Rename array_to_datetime to _array_to_datetime

    @seisman
    seisman committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    be3c93e View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. Merge branch 'main' into remove/array-to-datetime

    @seisman
    seisman authored Oct 19, 2024
    Configuration menu
    Copy the full SHA
    3d40687 View commit details
    Browse the repository at this point in the history

  2. Some numpy dtypes like np.float16 can't be recognized by GMT

    @seisman
    seisman committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    8f99a97 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Merge branch 'main' into remove/array-to-datetime

    @seisman
    seisman authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    5ecf445 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Merge branch 'main' into remove/array-to-datetime

    @seisman
    seisman authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    cd75c5c View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Merge branch 'main' into remove/array-to-datetime

    @seisman
    seisman committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    91e10a7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into remove/array-to-datetime

    @seisman
    seisman committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    47214e5 View commit details
    Browse the repository at this point in the history

  3. Check three variants for string dtypes

    @seisman
    seisman committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    d8777e5 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Merge branch 'main' into remove/array-to-datetime

    @seisman
    seisman committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    3286f08 View commit details
    Browse the repository at this point in the history

  2. Also check TypeError

    @seisman
    seisman committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    38b839a View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Merge branch 'main' into remove/array-to-datetime

    @seisman
    seisman committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    76cb837 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Merge branch 'main' into remove/array-to-datetime

    @seisman
    seisman committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    9573fb6 View commit details
    Browse the repository at this point in the history

  2. Remove the tests for pandas string dtypes

    @seisman
    seisman committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    bccae94 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2024

  1. Merge branch 'main' into remove/array-to-datetime

    @seisman
    seisman committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    d64c795 View commit details
    Browse the repository at this point in the history

  2. Remove the array_to_datetime function

    @seisman
    seisman committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    a410357 View commit details
    Browse the repository at this point in the history