Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session.virtualfile_from_vectors: Remove the deprecated '*args' parameter [deprecated since v0.14.0] #3893

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Session.virtualfile_from_vectors: Remove the deprecated '*args' parameter [deprecated since v0.14.0] #3893

wants to merge 4 commits into from
+1 −43

Conversation

seisman
Copy link
Member

@seisman seisman commented Apr 3, 2025

Related to #3522.

@seisman seisman added the deprecation Deprecating a feature label Apr 3, 2025
@seisman seisman added this to the 0.16.0 milestone Apr 3, 2025
@seisman seisman added the needs review This PR has higher priority and needs review. label Apr 4, 2025
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Apr 8, 2025
@seisman seisman requested a review from a team April 8, 2025 02:24
weiji14
weiji14 approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, but do you want to wait another week before merging this (and other deprecation PRs)? Or we're confident with the release branch workflow already 🙂

@seisman
Copy link
Member Author

seisman commented Apr 8, 2025

do you want to wait another week before merging this (and other deprecation PRs)?

OK with waiting another week. Will merge this PR on April 14.

This was referenced Apr 8, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelgrund michaelgrund michaelgrund approved these changes

@weiji14 weiji14 weiji14 approved these changes

Assignees
No one assigned
Labels
deprecation Deprecating a feature final review call This PR requires final review and approval from a second reviewer
Projects
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@seisman @michaelgrund @weiji14