Check Yaml Configuration correctness using Zod #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
costinsin
force-pushed
the
12-19-Check_Yaml_Configuration_correctness_using_Zod
branch
3 times, most recently
from
aa324f5 to
c4cb674
Compare
andreia-oca
requested changes
Dec 21, 2023
costinsin
force-pushed
the
12-19-Check_Yaml_Configuration_correctness_using_Zod
branch
from
c4cb674 to
67959e2
Compare
costinsin
deleted the
12-19-Check_Yaml_Configuration_correctness_using_Zod
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
We are using Zod, a runtime type check library to enforce the schema read from the configuration file.
This way, we can delegate the task to check the proper types and enforce required fields to Zod.
Checklist