Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable sh:minCount Constraint on AgentShape #1

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

hcvdwerf
Copy link
Collaborator

@hcvdwerf hcvdwerf commented Nov 5, 2024

Changes:
Removed sh:minCount from AgentShape properties.

Impact:
Loosens validation rules, making AgentShape properties optional and thus increasing compatibility with diverse datasets that may lack these fields.

Testing:
Save change to FDP it self

Reason for Change:
Ttrying to update the FDP itself still gives ''Unable to update entity data''. I have not created any specific entries yet, e.g. catalogs etc.

Copy link

@kburger kburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as a temporary workaround while we work out a more suitable solution.

@hcvdwerf hcvdwerf merged commit afd8e7d into main Nov 6, 2024
1 check failed
@hcvdwerf hcvdwerf deleted the disable-publisher-mincount branch November 6, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants