Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fairdatapoint extension #113

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Conversation

hcvdwerf
Copy link

@hcvdwerf hcvdwerf commented Aug 15, 2024

Summary by Sourcery

Remove the version specification from the docker-compose.yml file to align with the latest Docker Compose practices.

Build:

  • Remove the version specification from the docker-compose.yml file.

Copy link

sonarcloud bot commented Aug 15, 2024

Copy link

sourcery-ai bot commented Aug 15, 2024

Reviewer's Guide by Sourcery

This pull request removes the version specification from the docker-compose.yml file. The change is minimal but could have implications for Docker Compose compatibility and behavior.

File-Level Changes

Files Changes
docker-compose.yml Removed the 'version: "3"' line from the Docker Compose configuration

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hcvdwerf - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a comment in the docker-compose.yml file or updating the project documentation to explain the reasoning behind removing the version specification and which versions of Docker Compose are supported.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@hcvdwerf hcvdwerf merged commit 3fe7bb8 into main Aug 15, 2024
2 checks passed
@hcvdwerf hcvdwerf deleted the Update-fairdatapoint-extension- branch August 15, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants