fix(csv): resolve "extra data after last expected column" error #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enclosed fields containing commas in double quotes to ensure proper CSV parsing. This fix addresses the issue where extra data was detected after the last expected column.
kburger
reviewed
Jun 4, 2024
Comment on lines
1724
to
1725
| https://gdi.onemilliongenomes.eu,GDI,en | ||
| https://en.wikipedia.org/wiki/Colorectal_cancer,Colorectal cancer,en |
There was a problem hiding this comment.
I see not all lines have their label quoted. Should all labels be quoted for consistency sake, or are there specific cases that cause an issue?
There was a problem hiding this comment.
the problem was for comma in for example
http://purl.bioontology.org/ontology/ICD10CM/B34.2,"Coronavirus infection, unspecified",en
between Coronavirus infection and unspecified. This only happens with the new data added
|
kburger
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enclosed fields containing commas in double quotes to ensure proper CSV parsing. This fix addresses the issue where extra data was detected after the last expected column.