fix: ckan client api

[admy7]

🚀 Pull Request Checklist

• Title:

  • [ ] A brief, descriptive title for the changes.

• Description:

  • [ ] Provide a clear and concise description of your pull request, including the purpose of the changes and the approach you've taken.

• Context:

  • [ ] Why are these changes necessary? What problem do they solve? Link any related issues.

• Changes:

  • [ ] List the major changes you've made, ideally organized by commit or feature.

• Testing:

  • [ ] Describe how the changes have been tested. Include any relevant details about the testing environment and the test cases.

• Screenshots (if applicable):

  • [ ] If your changes are visual, include screenshots to help explain your changes.

• Additional Information:

  • [ ] Add any other information that might be useful for reviewers, such as considerations, discussions, or dependencies.

• Checklist:

  • [ ] I have checked that my code adheres to the project's style guidelines and that my code is well-commented.
  • [ ] I have performed self-review of my own code and corrected any misspellings.
  • [ ] I have made corresponding changes to the documentation (if applicable).
  • [ ] My changes generate no new warnings or errors.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [ ] New and existing unit tests pass locally with my changes.

Summary by Sourcery

Fix the CKAN client API by removing the 'returnFields' parameter from method calls to resolve issues with its handling.

Bug Fixes:

• Fix the CKAN client API by removing the 'returnFields' parameter from various method calls to prevent errors related to its usage.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request modifies the CKAN client API to remove the 'returnFields' parameter and adjust how null values are handled in various API calls. The changes are implemented across multiple Java classes and the OpenAPI specification.

File-Level Changes

Change	Details	Files
Removed 'returnFields' parameter from API calls and method signatures	Removed 'returnFields' parameter from CkanDatasetsRepository.search() method Removed 'returnFields' parameter from DatasetsRepository interface Removed 'returnFields' parameter from SearchDatasetsQuery.execute() method Removed 'returnFields' field from DatasetSearchQuery schema in OpenAPI specification	src/main/java/io/github/genomicdatainfrastructure/discovery/datasets/infrastructure/ckan/persistence/CkanDatasetsRepository.java src/main/java/io/github/genomicdatainfrastructure/discovery/datasets/application/ports/DatasetsRepository.java src/main/java/io/github/genomicdatainfrastructure/discovery/datasets/application/usecases/SearchDatasetsQuery.java src/main/openapi/discovery.yaml
Modified API calls to use null instead of empty strings or default values	Changed empty string parameters to null in CkanFacetsBuilder Changed empty string parameters to null in CkanDatasetsRepository Changed empty string parameters to null in CkanDatasetIdsCollector	src/main/java/io/github/genomicdatainfrastructure/discovery/datasets/infrastructure/ckan/persistence/CkanFacetsBuilder.java src/main/java/io/github/genomicdatainfrastructure/discovery/datasets/infrastructure/ckan/persistence/CkanDatasetsRepository.java src/main/java/io/github/genomicdatainfrastructure/discovery/datasets/infrastructure/ckan/persistence/CkanDatasetIdsCollector.java

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sourcery-ai]

Hey @admy7 - I've reviewed your changes - here's some feedback:

Overall Comments:

• Please provide more context about why these changes were necessary and how they affect the API's functionality, especially regarding the removal of the returnFields parameter.
• Can you describe how these changes have been tested, particularly the replacement of empty strings with null values in API calls?

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}