-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: (ART-10521) add local otel collector #166
Conversation
Reviewer's Guide by SourceryThis PR adds OpenTelemetry (OTEL) collector and Jaeger services to the local development environment. The implementation involves configuring Docker services and setting up the OTEL collector to receive and forward telemetry data to Jaeger. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jadzlnds - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please fill out the PR template sections to provide context about the changes, testing performed, and any other relevant information.
- Consider using specific versions instead of 'latest' tags for the Docker images to ensure reproducible deployments and avoid unexpected changes.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
🚀 Pull Request Checklist
Title:
[ ]
A brief, descriptive title for the changes.Description:
[ ]
Provide a clear and concise description of your pull request, including the purpose of the changes and the approach you've taken.Context:
[ ]
Why are these changes necessary? What problem do they solve? Link any related issues.Changes:
[ ]
List the major changes you've made, ideally organized by commit or feature.Testing:
[ ]
Describe how the changes have been tested. Include any relevant details about the testing environment and the test cases.Screenshots (if applicable):
[ ]
If your changes are visual, include screenshots to help explain your changes.Additional Information:
[ ]
Add any other information that might be useful for reviewers, such as considerations, discussions, or dependencies.Checklist:
[ ]
I have checked that my code adheres to the project's style guidelines and that my code is well-commented.[ ]
I have performed self-review of my own code and corrected any misspellings.[ ]
I have made corresponding changes to the documentation (if applicable).[ ]
My changes generate no new warnings or errors.[ ]
I have added tests that prove my fix is effective or that my feature works.[ ]
New and existing unit tests pass locally with my changes.Summary by Sourcery
Add a local OpenTelemetry collector and Jaeger service to the Docker Compose setup to enhance telemetry and tracing capabilities. Configure the OTel collector with a new YAML file to manage data flow.
New Features:
Enhancements:
Deployment: