fix: #17 Retrieve Beacon Facets when logged-in #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beacon facets must be retrieved if the user is logged in, no matter if the user is using or not beacon facets to filter the results. The class `BeaconDatasetsSearchService` was altered to comply to this requirement: - if the user is not logged-in automatically CKAN query is triggered without enhancement. Check line 75. - If there are beacon queries we trigger a search on Beacon Network. Check lines 79 and 109. - if there are no beacon filters or beacon's resultsets is not empty, we query on CKAN. Check lines 81 and 134. - Beacon facets/filters are always inserted into CKAN output. Check lines 87 and 175. With those rules, we are able to properly enrich CKAN output with beacon response, including facets and resultsets, if there is any. Several different test cases were introduced to cover most of the scenarios.
brunopacheco1
requested review from
inderps,
sulejmank,
EmiPali,
admy7 and
nolliia
1 task
sulejmank
approved these changes
Apr 16, 2024
brunopacheco1
deleted the
17-gdi-dataset-discovery-service-beacon-facet-group-is-not-retrieved-when-empty-query
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beacon facets must be retrieved if the user is logged in, no matter if the user is using or not beacon facets to filter the results.
The class
BeaconDatasetsSearchServicewas altered to comply to this requirement:With those rules, we are able to properly enrich CKAN output with beacon response, including facets and resultsets, if there is any.
Several different test cases were introduced to cover most of the scenarios.