Merge pull request #254 from GenomicDataInfrastructure/251-gdi-fronte…

…nd-empty-400-when-submitting-empty-form fix: fetch application request fails silently and makes renedering is…
GenomicDataInfrastructure · May 24, 2024 · 5c883c9 · 5c883c9
2 parents 6977f80 + d8e2faa
commit 5c883c9
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 4 deletions.
diff --git a/src/app/applications/[id]/page.tsx b/src/app/applications/[id]/page.tsx
@@ -44,7 +44,23 @@ export default function ApplicationDetailsPage() {
     }
   }, [error]);
 
-  if (!application) return;
+  if (!application) {
+    return (
+      <PageContainer>
+        {alert && (
+          <Alert
+            type={alert.type}
+            message={alert.message}
+            onClose={() => {
+              onCloseAlert();
+              clearError();
+            }}
+            className="mb-8"
+          />
+        )}
+      </PageContainer>
+    );
+  }
 
   const events = application.events;
   const lastEvent = events[0];

diff --git a/src/providers/application/ApplicationProvider.tsx b/src/providers/application/ApplicationProvider.tsx
@@ -130,14 +130,15 @@ function ApplicationProvider({ children }: ApplicationProviderProps) {
 
   const fetchApplication = useCallback(async () => {
     dispatch({ type: ApplicationActionType.LOADING });
-    try {
-      const response = await fetch(`/api/applications/${id}`);
+    const response = await fetch(`/api/applications/${id}`);
+
+    if (response.ok) {
       const retrievedApplication = await response.json();
       dispatch({
         type: ApplicationActionType.APPLICATION_LOADED,
         payload: retrievedApplication,
       });
-    } catch {
+    } else {
       dispatch({
         type: ApplicationActionType.REJECTED,
         payload: "Failed to fetch application",