Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcb-Topic - Added the "Topic" of an SOP to metadata, scripts and template #26

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

M-casado
Copy link
Collaborator

Summary

Added the "Topic" of an SOP to metadata, scripts and template

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change which adds new content)
  • Modified content (non-breaking change which modifies existing content)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Motivation and Context

We subdivided SOPs by topic, but in previous iterations I forgot to add that part to the metadata of SOPs, and to take that column into account for the scripts.

References

NA

Changes Introduced

  • Added Topic to general template
  • Added Topic to columns to expect in the metadata table for linting
  • Added Topic to the sop index table that is created and compared automatically

Review

Not yet

Checklist:

General Compliance:

  • My changes follow the code style of this project (GDI SOP Style Guide) and the file naming conventions of the file accessioning proposal.
  • I have verified that all new updated content is accessible, including checking that all external references are readable (i.e., no broken links). These may include references to external resources that should be resolvable, and internal references among SOPs.
  • I have properly added this PR's changes to the repository CHANGELOG.md.

Only applicable if the PR includes new, or changes to, GDI SOPs (i.e., documents at sops/):

  • My SOP-related changes adhere to the Generic SOP Template, including format and required fields.
  • I have consulted the Charter, ISM, and ORR documents to ensure compliance.
  • I am complying with the established procedure for SOP creations and modifications, including respecting review phases and notifying needed contributors for reviews.

@M-casado
Copy link
Collaborator Author

(Take into account that automatic checks will fail for now, because there are no SOPs, and it's complaining as intended)

Copy link

@elisavettorstensson elisavettorstensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of the changes you made. Nice!

@M-casado M-casado merged commit 573a8ab into GenomicDataInfrastructure:main Aug 16, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants