Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatter / DCAT / Add some more media type mapping to EU vocabuary #113

Merged

Conversation

fxprunayre
Copy link

If no match, data.europa.eu display UNKNOWN.

image

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

If no match, data.europa.eu display UNKNOWN.
@CLAassistant
Copy link

CLAassistant commented Feb 19, 2025

CLA assistant check
All committers have signed the CLA.

Comment on lines +136 to +137
<entry key="http://publications.europa.eu/resource/authority/file-type/GeoTIFF">geotiff</entry>
<entry key="http://publications.europa.eu/resource/authority/file-type/GeoTIFF">application/x-worldfile</entry>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 2 keys are the same, is this correct?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the mapping here is to convert distribution format or "WWW:DOWNLOAD:format" protocol values to the EU vocabulary. So various values may be used. Here geotiff are sometimes using application/x-worldfile for the world file.

@josegar74 josegar74 merged commit 30dee27 into GeoCat:44-dcat-formatter-improvements Feb 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants