Skip to content

Commit

Permalink
"feat: reverts commit 'allow go test results to upload to s3'"
Browse files Browse the repository at this point in the history
This reverts commit 209d96c.
Was getting this error when using the action in go-reusable-app: exceed the limit on called workflow depth of 3
  • Loading branch information
CallumNZ committed Oct 11, 2024
1 parent 209d96c commit 39eed06
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 26 deletions.
22 changes: 0 additions & 22 deletions .github/workflows/reusable-go-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,6 @@ name: reusable go test
on:
workflow_call:
inputs:
aws-role-arn-to-assume:
type: string
required: false
description: |
role to use to upload test results to s3 bucket,
see reusable-copy-to-s3 workflow for more detail.
s3-bucket:
type: string
required: false
description: |
the AWS S3 bucket name to upload test results to.
setup:
required: false
type: string
Expand Down Expand Up @@ -60,14 +49,3 @@ jobs:
/tmp/coverage.html
if-no-files-found: error
retention-days: 1
go-test-upload:
needs: go-test
if: ${{ inputs.aws-role-arn-to-assume && inputs.s3-bucket }}
uses: GeoNet/Actions/.github/workflows/reusable-copy-to-s3.yml@main
with:
aws-role-arn-to-assume: ${{ inputs.aws-role-arn-to-assume }}
artifact-name: test-results
artifact-path: ./coverage
s3-bucket: s3://${{inputs.s3-bucket}}/test-coverage-results/${{github.repository}}/go/
cp-or-sync: cp
direction: to
4 changes: 0 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -605,13 +605,9 @@ on:
jobs:
go-test:
uses: GeoNet/Actions/.github/workflows/reusable-go-test.yml@main
with:
aws-role-arn-to-assume: github-to-s3-upload-role
s3-bucket: my-bucket
```

test coverage results upload to job artifacts, found at the bottom of a job summary page.
An optional bucket and role can be provided to upload the results to S3 as well.

### Go vulnerability check

Expand Down

0 comments on commit 39eed06

Please sign in to comment.