Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: allow go test results to upload to s3" #307

Merged
merged 1 commit into from
Oct 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions .github/workflows/reusable-go-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,6 @@ name: reusable go test
on:
workflow_call:
inputs:
aws-role-arn-to-assume:
type: string
required: false
description: |
role to use to upload test results to s3 bucket,
see reusable-copy-to-s3 workflow for more detail.
s3-bucket:
type: string
required: false
description: |
the AWS S3 bucket name to upload test results to.
setup:
required: false
type: string
Expand Down Expand Up @@ -60,14 +49,3 @@ jobs:
/tmp/coverage.html
if-no-files-found: error
retention-days: 1
go-test-upload:
needs: go-test
if: ${{ inputs.aws-role-arn-to-assume && inputs.s3-bucket }}
uses: GeoNet/Actions/.github/workflows/reusable-copy-to-s3.yml@main
with:
aws-role-arn-to-assume: ${{ inputs.aws-role-arn-to-assume }}
artifact-name: test-results
artifact-path: ./coverage
s3-bucket: s3://${{inputs.s3-bucket}}/test-coverage-results/${{github.repository}}/go/
cp-or-sync: cp
direction: to
4 changes: 0 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -605,13 +605,9 @@ on:
jobs:
go-test:
uses: GeoNet/Actions/.github/workflows/reusable-go-test.yml@main
with:
aws-role-arn-to-assume: github-to-s3-upload-role
s3-bucket: my-bucket
```

test coverage results upload to job artifacts, found at the bottom of a job summary page.
An optional bucket and role can be provided to upload the results to S3 as well.

### Go vulnerability check

Expand Down
Loading