Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add composite action for copying to s3 #311

Merged
merged 3 commits into from
Jan 28, 2025
Merged

feat: add composite action for copying to s3 #311

merged 3 commits into from
Jan 28, 2025

Conversation

CallumNZ
Copy link
Contributor

Adapted from reusable-copy-to-s3 workflow. Having it as a composite action should help address the workflow nesting limit that we see in some situations

@CallumNZ CallumNZ force-pushed the caS3 branch 6 times, most recently from 6e363d5 to e58fb7d Compare October 16, 2024 21:42
@CallumNZ CallumNZ marked this pull request as ready for review October 16, 2024 21:47
@CallumNZ CallumNZ requested a review from wilsonjord October 16, 2024 21:47
@CallumNZ CallumNZ force-pushed the caS3 branch 3 times, most recently from 5d8f5c1 to ae875b4 Compare October 17, 2024 00:45
Adapted from reusable-copy-to-s3 workflow. Having it as a composite action should help address the workflow nesting limit that we see in some situations
Adapted from reusable-copy-to-s3 workflow. Having it as a composite action should help address the workflow nesting limit that we see in some situations
Copy link
Contributor

@wilsonjord wilsonjord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR appears to add new functionality.
Last question, is the intention to reimplement the current reusable s3 workflow to use these? Or are these intended for use for those hitting the nesting workflow limit?

@CallumNZ
Copy link
Contributor Author

CallumNZ commented Jan 28, 2025

PR appears to add new functionality. Last question, is the intention to reimplement the current reusable s3 workflow to use these? Or are these intended for use for those hitting the nesting workflow limit?

The driving force was the nesting limit, but yes, once this is stable we can do that for DRYness.

@CallumNZ CallumNZ merged commit 8dde320 into main Jan 28, 2025
16 checks passed
@CallumNZ CallumNZ deleted the caS3 branch January 28, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants