Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLnz20 Original calibration - table and reference #2242

Merged
merged 5 commits into from
Dec 10, 2024

Conversation

salichon
Copy link
Contributor

Provisional entry for magnitude calibration (MLnz20)

@salichon
Copy link
Contributor Author

WIP - will update with the station correction

@salichon
Copy link
Contributor Author

Need an entry in README

@salichon salichon force-pushed the MLnzCalibTable branch 3 times, most recently from 5b63305 to b98cf2c Compare September 26, 2024 22:48
MLnz20 entries

Set Station Correction-calibration for MLNz20
staylorofford
staylorofford previously approved these changes Oct 17, 2024
Copy link
Contributor

@staylorofford staylorofford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Barring one comment to consider and assuming the corrections are pulled straight from the Table S3.csv, LGTM.

@elidana
Copy link
Contributor

elidana commented Nov 11, 2024

just a comment as I bumped into this. In delta, we already have a calibration folder, that is used to upload instrument-specific laboratory calibrations (currently for GNSS antennas and fluxgates).
I wonder if we should use a different terminology for site-specific magnitude calibration factors?

@staylorofford
Copy link
Contributor

Good call @elidana. They are not calibrations in a true sense but corrections used to improve magnitude scale model fit. Can we just use corrections terminology @salichon ?

@salichon
Copy link
Contributor Author

salichon commented Dec 6, 2024

@staylorofford Okay
I ll use the same terminology as the paper

@salichon salichon marked this pull request as ready for review December 10, 2024 01:46
@salichon salichon requested a review from a team as a code owner December 10, 2024 01:46
@salichon
Copy link
Contributor Author

@staylorofford @Thomas-Benson Up we go .
Changed the file names and add citation - and do it for real

@salichon salichon merged commit e166d27 into GeoNet:main Dec 10, 2024
9 checks passed
@ozym
Copy link
Contributor

ozym commented Dec 10, 2024

This is probably not how I would have laid out this file.

I'd think:

(a) Is the notes field really necessary? I'd much prefer a "lookup table" if there was something to say, free form fields are hard to validate, and is it needed.
(b) I tend to want to put the dates at the end of the list of columns (the notes tend to end up there due to external forces).
(c) The citations should ideally be done in alphabetical order, which is deterministic (e.g. A2023 B2024 vs B2024 A2023 is the same but different).

In the past there wasn't really any concept of a location code when it came to station corrections, do you therefore need to keep track of all variations, and magnitude differences related to boreholes would be very hard to isolate. Jury is out on this one, as it really limits when these corrections can be applied.

@salichon
Copy link
Contributor Author

Hello @ozym !
thanks :)
fair enough, will keep working on that one indeed,
FYI @staylorofford
and Follow up on the ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants