nfc: extend table foreign keys to include column names #2293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is aimed at better building sql tables, and includes being more specific about the foreign keys by including column names, and adding any columns that can be set to null, as well as any columns that can't but have a default to avoid this. There are likely to be some other fields with defaults, but at the moment it is not clear what the value should be, e.g. a blank entry may mean all values. Perhaps some form of expression is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is aimed at better building sql tables, and includes being more specific about the foreign keys by including column names, and adding any columns that can be set to null, as well as any columns that can't but have a default to avoid this.
There are likely to be some other fields with defaults, but at the moment it is not clear what the value should be, e.g. a blank entry may mean all values. Perhaps some form of expression is needed.
The current implementation is a proof of concept, whereas the next iteration will hopefully aim at a more designed solution.
It also fixes a few misconfigured foreign key tables which had no impact.