Skip to content

Commit

Permalink
Merge pull request #1101 from Geode-solutions/fix/solid-degen-area
Browse files Browse the repository at this point in the history
fix(SolidMesh): remove wrong test in degenerated check
  • Loading branch information
MelchiorSchuh authored Mar 6, 2025
2 parents 15f0ae0 + 7423cfe commit dfcb522
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions src/geode/mesh/core/solid_mesh.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -908,10 +908,6 @@ namespace geode
max_area_facet = f;
}
}
if( max_area < GLOBAL_EPSILON )
{
return true;
}
const auto vertices = polyhedron_vertices( polyhedron_id );
const auto normal =
polyhedron_facet_normal( { polyhedron_id, max_area_facet } );
Expand All @@ -924,8 +920,7 @@ namespace geode
Plane plane{ normal.value(), this->point( facet_vertices[0] ) };
for( const auto vertex_id : vertices )
{
if( absl::c_find( facet_vertices, vertex_id )
!= facet_vertices.end() )
if( absl::c_contains( facet_vertices, vertex_id ) )
{
continue;
}
Expand Down

0 comments on commit dfcb522

Please sign in to comment.